1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
package corredor
import (
"context"
"github.com/cortezaproject/corteza-server/pkg/sentry"
"github.com/go-chi/chi/middleware"
"github.com/pkg/errors"
"go.uber.org/zap"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/status"
"time"
"github.com/cortezaproject/corteza-server/pkg/app/options"
"github.com/cortezaproject/corteza-server/pkg/auth"
"github.com/cortezaproject/corteza-server/pkg/eventbus"
"github.com/cortezaproject/corteza-server/pkg/permissions"
"github.com/cortezaproject/corteza-server/system/types"
)
type (
service struct {
// stores corredor connection options
// for when we're doing lazy setup
opt options.CorredorOpt
// list of all registered event handlers
// map[<script-name>]
registered map[string][]uintptr
// list of all registered explicitly executable script
// map[<script-name>][<resource>] = true
explicit map[string]map[string]bool
// Combined list of client and server scripts
sScripts ScriptSet
sScriptsTS time.Time
cScripts ScriptSet
cScriptsTS time.Time
conn *grpc.ClientConn
ssClient ServerScriptsClient
csClient ClientScriptsClient
log *zap.Logger
eventRegistry eventRegistry
authTokenMaker authTokenMaker
// Services to help with script security
// we'll find users (runAs) and roles (allow, deny) for
users userFinder
roles roleFinder
// set of permission rules, generated from security info of each script
permissions permissions.RuleSet
}
ScriptArgs interface {
eventbus.Event
// Encode (event) to arguments passed to
// event handlers ([automation ]script runner)
Encode() (map[string][]byte, error)
// Decodes received data back to event
Decode(map[string][]byte) error
}
eventRegistry interface {
Register(h eventbus.HandlerFn, ops ...eventbus.HandlerRegOp) uintptr
Unregister(ptrs ...uintptr)
}
userFinder interface {
FindByAny(interface{}) (*types.User, error)
}
roleFinder interface {
FindByAny(interface{}) (*types.Role, error)
}
authTokenMaker interface {
Encode(auth.Identifiable) string
}
permissionRuleChecker interface {
Check(res permissions.Resource, op permissions.Operation, roles ...uint64) permissions.Access
}
)
const onManualEventType = "onManual"
var (
// Global corredor service
gCorredor *service
)
const (
permOpExec permissions.Operation = "exec"
)
func Service() *service {
return gCorredor
}
// Start connects to Corredor & initialize service
func Setup(logger *zap.Logger, opt options.CorredorOpt) (err error) {
if gCorredor != nil {
// Prevent multiple initializations
return
}
gCorredor = NewService(logger, opt)
return
}
func NewService(logger *zap.Logger, opt options.CorredorOpt) *service {
return &service{
log: logger.Named("corredor"),
opt: opt,
registered: make(map[string][]uintptr),
explicit: make(map[string]map[string]bool),
authTokenMaker: auth.DefaultJwtHandler,
eventRegistry: eventbus.Service(),
permissions: permissions.RuleSet{},
}
}
func (svc *service) Connect(ctx context.Context) (err error) {
if !svc.opt.Enabled {
return
}
if err = svc.connect(ctx); err != nil {
return
}
svc.ssClient = NewServerScriptsClient(svc.conn)
svc.csClient = NewClientScriptsClient(svc.conn)
return
}
func (svc *service) connect(ctx context.Context) (err error) {
if svc.conn, err = NewConnection(ctx, svc.opt, svc.log); err != nil {
return
}
return
}
// Watch watches for changes
func (svc *service) Watch(ctx context.Context) {
go func() {
defer sentry.Recover()
var ticker = time.NewTicker(svc.opt.ListRefresh)
defer ticker.Stop()
for {
select {
case <-ctx.Done():
return
case <-ticker.C:
svc.Load(ctx)
}
}
}()
svc.log.Debug("watcher initialized")
}
func (svc *service) SetEventRegistry(er eventRegistry) {
svc.eventRegistry = er
}
func (svc *service) SetAuthTokenMaker(atm authTokenMaker) {
svc.authTokenMaker = atm
}
func (svc *service) SetUserFinder(uf userFinder) {
svc.users = uf
}
func (svc *service) SetRoleFinder(rf roleFinder) {
svc.roles = rf
}
func (svc *service) Load(ctx context.Context) {
if !svc.opt.Enabled {
return
}
go svc.loadServerScripts(ctx)
go svc.loadClientScripts(ctx)
}
// Find returns filtered list of scripts that can be manually triggered
func (svc service) Find(ctx context.Context, filter Filter) (out ScriptSet, f Filter, err error) {
f = filter
var (
tmp ScriptSet
scriptFilter = svc.makeScriptFilter(ctx, f)
)
if !f.ExcludeServerScripts {
tmp, err = svc.sScripts.Filter(scriptFilter)
out = append(out, tmp...)
}
if !f.ExcludeClientScripts {
tmp, err = svc.cScripts.Filter(scriptFilter)
out = append(out, tmp...)
}
f.Count = uint(len(out))
return
}
// An enhanced version of basic script filter maker (from util.go)
// that (after basic filtering) also does RBAC check for each script
func (svc service) makeScriptFilter(ctx context.Context, f Filter) func(s *Script) (b bool, err error) {
var (
base = f.makeFilterFn()
)
return func(s *Script) (b bool, err error) {
if b, err = base(s); !b {
return
}
return svc.canExec(ctx, s.Name), nil
}
}
// Exec verifies permissions, event and script and sends exec request to corredor
func (svc service) Exec(ctx context.Context, scriptName string, args ScriptArgs) (err error) {
if !svc.opt.Enabled {
return
}
var (
res = args.ResourceType()
script *Script
ok bool
runAs string
)
if len(scriptName) == 0 {
return errors.Errorf("script name not provided (%q)", scriptName)
}
if _, ok = svc.explicit[scriptName]; !ok {
return errors.Errorf("unregistered explicit script %q", scriptName)
}
if _, ok = svc.explicit[scriptName][res]; !ok {
return errors.Errorf("unregistered explicit script %q for resource %q", scriptName, res)
}
if script = svc.sScripts.FindByName(scriptName); script == nil {
return errors.Errorf("nonexistent script (%q)", scriptName)
}
if !svc.canExec(ctx, scriptName) {
return errors.Errorf("permission to execute %s denied", scriptName)
}
if script.Security != nil {
runAs = script.Security.RunAs
}
return svc.exec(ctx, scriptName, runAs, args)
}
// Can current user execute this script
//
// This is used only in case of explicit execution (onManual) and never when
// scripts are executed implicitly (deferred, before/after...)
func (svc service) canExec(ctx context.Context, script string) bool {
u := auth.GetIdentityFromContext(ctx)
if auth.IsSuperUser(u) {
return true
}
return svc.permissions.Check(permissions.Resource(script), permOpExec, u.Roles()...) != permissions.Deny
}
func (svc *service) loadServerScripts(ctx context.Context) {
var (
err error
rsp *ServerScriptListResponse
)
ctx, cancel := context.WithTimeout(ctx, svc.opt.ListTimeout)
defer cancel()
if !svc.sScriptsTS.IsZero() {
ctx = metadata.NewOutgoingContext(ctx, metadata.MD{
"if-modified-since": []string{svc.sScriptsTS.Format(time.RFC3339)},
})
}
rsp, err = svc.ssClient.List(ctx, &ServerScriptListRequest{}, grpc.WaitForReady(true))
if err != nil {
svc.log.Error("could not load corredor server scripts", zap.Error(err))
return
}
svc.sScriptsTS = time.Now()
if len(rsp.Scripts) > 0 {
svc.log.Debug("reloading server scripts")
svc.registerServerScripts(rsp.Scripts...)
}
}
// Registers Corredor scripts to eventbus and list of manual scripts
func (svc *service) registerServerScripts(ss ...*ServerScript) {
var (
permRuleGenerator = func(script string, access permissions.Access, roles ...string) (permissions.RuleSet, error) {
out := make([]*permissions.Rule, len(roles))
for i, role := range roles {
if r, err := svc.roles.FindByAny(role); err != nil {
return nil, err
} else {
out[i] = &permissions.Rule{
RoleID: r.ID,
Resource: permissions.Resource(script),
Operation: permOpExec,
Access: access,
}
}
}
return out, nil
}
u *types.User
err error
runAs = ""
)
svc.sScripts = make([]*Script, 0, len(ss))
// Remove all previously registered triggers
for _, ptrs := range svc.registered {
if len(ptrs) > 0 {
svc.eventRegistry.Unregister(ptrs...)
}
}
// Reset indexes
svc.registered = make(map[string][]uintptr)
svc.explicit = make(map[string]map[string]bool)
// Reset security
svc.permissions = permissions.RuleSet{}
for _, script := range ss {
var (
// collectors for allow&deny rules
// we'll merge
allow = permissions.RuleSet{}
deny = permissions.RuleSet{}
)
if nil != svc.sScripts.FindByName(script.Name) {
// Do not allow duplicated scripts
continue
}
s := &Script{
Name: script.Name,
Label: script.Label,
Description: script.Description,
Errors: script.Errors,
Triggers: script.Triggers,
Security: &ScriptSecurity{Security: script.Security},
}
scriptErrPush := func(err error, msg string) {
s.Errors = append(s.Errors, errors.Wrap(err, msg).Error())
}
if len(s.Errors) == 0 {
if manual := mapExplicitTriggers(script); len(manual) > 0 {
if script.Security != nil {
runAs = script.Security.RunAs
if runAs != "" {
// Prefetch run-as user
if u, err = svc.users.FindByAny(runAs); err != nil {
scriptErrPush(err, "could not load run-as user security info")
} else {
s.Security.runAs = u.ID
}
}
if allow, err = permRuleGenerator(script.Name, permissions.Allow, script.Security.Allow...); err != nil {
scriptErrPush(err, "could not load allow role security info")
}
if deny, err = permRuleGenerator(script.Name, permissions.Deny, script.Security.Deny...); err != nil {
scriptErrPush(err, "could not load deny role security info")
}
svc.permissions = append(svc.permissions, allow...)
svc.permissions = append(svc.permissions, deny...)
}
svc.explicit[script.Name] = manual
}
svc.registered[script.Name] = svc.registerTriggers(script)
svc.log.Debug(
"script registered",
zap.String("script", s.Name),
zap.Int("explicit", len(svc.explicit[script.Name])),
zap.Int("triggers", len(svc.registered[script.Name])),
)
} else {
svc.log.Warn(
"script loaded with errors",
zap.String("script", s.Name),
zap.Strings("errors", s.Errors),
)
}
}
}
// Creates handler function for eventbus subsystem
func (svc *service) registerTriggers(script *ServerScript) []uintptr {
var (
ops []eventbus.HandlerRegOp
err error
ptrs = make([]uintptr, 0, len(script.Triggers))
log = svc.log.With(zap.String("script", script.Name))
runAs string
)
if script.Security != nil {
runAs = script.Security.RunAs
}
for i := range script.Triggers {
if ops, err = triggerToHandlerOps(script.Triggers[i]); err != nil {
log.Warn(
"could not make trigger options",
zap.Error(err),
)
continue
}
if len(ops) == 0 {
continue
}
ptr := svc.eventRegistry.Register(func(ctx context.Context, ev eventbus.Event) (err error) {
// Is this compatible event?
if ce, ok := ev.(ScriptArgs); ok {
// Can only work with corteza compatible events
return svc.exec(ctx, script.Name, runAs, ce)
}
return nil
}, ops...)
ptrs = append(ptrs, ptr)
}
return ptrs
}
// Exec finds and runs specific script with given event
//
// It does not do any constraints checking - this is the responsibility of the
// individual event implemntation
func (svc service) exec(ctx context.Context, script string, runAs string, args ScriptArgs) (err error) {
var (
requestId = middleware.GetReqID(ctx)
rsp *ExecResponse
invoker auth.Identifiable
encodedEvent map[string][]byte
encodedResults = make(map[string][]byte)
log = svc.log.With(
zap.String("script", script),
zap.String("runAs", runAs),
zap.String("args", args.EventType()),
zap.String("resource", args.ResourceType()),
)
)
log.Debug("triggered")
if encodedEvent, err = args.Encode(); err != nil {
return
}
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
// Additional ([]byte) arguments
req := &ExecRequest{
Name: script,
Args: make(map[string]string),
}
// Cast arguments from map[string]json.RawMessage to map[string]string
for key := range encodedEvent {
req.Args[key] = string(encodedEvent[key])
}
// Resolve/expand invoker user details from the context (if present
if i := auth.GetIdentityFromContext(ctx); i.Valid() {
invoker, err = svc.users.FindByAny(i)
if err != nil {
return err
}
log = log.With(zap.Stringer("invoker", invoker))
if err = encodeArguments(req.Args, "invoker", invoker); err != nil {
return
}
}
if len(runAs) > 0 {
if !svc.opt.RunAsEnabled {
return errors.New("could not make runner context, run-as disabled")
}
var definer auth.Identifiable
// Run this script as defined user
//
// We search for the defined (run-as) user,
// assign it to authUser argument and make an
// authentication token for it
definer, err = svc.users.FindByAny(runAs)
if err != nil {
return err
}
log = log.With(zap.Stringer("run-as", definer))
// current (authenticated) user
if err = encodeArguments(req.Args, "authUser", definer); err != nil {
return
}
if err = encodeArguments(req.Args, "authToken", svc.authTokenMaker.Encode(definer)); err != nil {
return
}
} else if invoker != nil {
// Run script with the same user that invoked it
// current (authenticated) user
if err = encodeArguments(req.Args, "authUser", invoker); err != nil {
return
}
if err = encodeArguments(req.Args, "authToken", svc.authTokenMaker.Encode(invoker)); err != nil {
return
}
}
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
// Additional (string) arguments
// basic args/event info
if err = encodeArguments(req.Args, "args", args.EventType()); err != nil {
return
}
if err = encodeArguments(req.Args, "resource", args.ResourceType()); err != nil {
return
}
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
ctx, cancel := context.WithTimeout(
// We need a new, independent context here
// to be sure this is executed safely & fully
// without any outside interfeance (cancellation, timeouts)
context.Background(),
svc.opt.DefaultExecTimeout,
)
defer cancel()
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
ctx = metadata.NewOutgoingContext(ctx, metadata.MD{
"x-request-id": []string{requestId},
})
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
var header, trailer metadata.MD
rsp, err = svc.ssClient.Exec(
ctx,
req,
grpc.WaitForReady(true),
grpc.Header(&header),
grpc.Trailer(&trailer),
)
if err != nil {
// See if this was a "soft abort"
//
// This means, we do not make any logs of this just
// tell the caller that the call was aborted
s := status.Convert(err)
if s != nil && s.Code() == codes.Aborted {
// Special care for errors with Aborted code
msg := s.Message()
if len(msg) == 0 {
// No extra message, fallback to "aborted"
msg = "Aborted"
}
return errors.New(msg)
}
log.Warn("corredor responded with error", zap.Error(err))
return errors.New("failed to execute corredor script")
}
log.Info("executed", zap.Any("result", rsp.Result))
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
// @todo process metadata (log, errors, stacktrace)
// spew.Dump("grpc exec header", header)
// spew.Dump("grpc exec trailer", trailer)
if rsp.Result == nil {
// No results
return
}
// Cast map[string]json.RawMessage to map[string]string
for key := range rsp.Result {
encodedResults[key] = []byte(rsp.Result[key])
}
// Send results back to the args for decoding
err = args.Decode(encodedResults)
if err != nil {
log.Debug(
"could not decode results",
zap.Error(err),
zap.Any("results", encodedResults),
)
return
}
// Everything ok
return
}
func (svc *service) loadClientScripts(ctx context.Context) {
var (
err error
rsp *ClientScriptListResponse
)
ctx, cancel := context.WithTimeout(ctx, svc.opt.ListTimeout)
defer cancel()
if !svc.sScriptsTS.IsZero() {
ctx = metadata.NewOutgoingContext(ctx, metadata.MD{
"if-modified-since": []string{svc.sScriptsTS.Format(time.RFC3339)},
})
}
rsp, err = svc.csClient.List(ctx, &ClientScriptListRequest{}, grpc.WaitForReady(true))
if err != nil {
svc.log.Error("could not load corredor client scripts", zap.Error(err))
return
}
svc.sScriptsTS = time.Now()
if len(rsp.Scripts) > 0 {
svc.log.Debug("reloading client scripts")
svc.registerClientScripts(rsp.Scripts...)
}
}
func (svc *service) registerClientScripts(ss ...*ClientScript) {
svc.cScripts = make([]*Script, len(ss))
for i, script := range ss {
svc.cScripts[i] = &Script{
Name: script.Name,
Label: script.Label,
Description: script.Description,
Errors: script.Errors,
Triggers: script.Triggers,
Bundle: script.Bundle,
Type: script.Type,
}
}
}
func (svc *service) GetBundle(ctx context.Context, name, bType string) *Bundle {
if !svc.opt.Enabled {
return nil
}
var (
err error
rsp *BundleResponse
)
ctx, cancel := context.WithTimeout(ctx, svc.opt.ListTimeout)
defer cancel()
rsp, err = svc.csClient.Bundle(ctx, &BundleRequest{Name: name}, grpc.WaitForReady(true))
if err != nil {
svc.log.Error("could not load client scripts bundle from corredor", zap.Error(err))
return nil
}
for _, b := range rsp.Bundles {
if b.Type == bType {
return b
}
}
return nil
}